Skip to content

Make gatsby-node more clear for /code page #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from Apr 4, 2023
Merged

Make gatsby-node more clear for /code page #1377

merged 4 commits into from Apr 4, 2023

Conversation

@TuvalSimha
Copy link
Contributor

@TuvalSimha TuvalSimha commented Mar 7, 2023 •
edited
Loading

  1. Make onCreatePage for /code path clear
  2. Split into 3 different function
  3. Make the flow type safe
  4. Make Services handle "General" sub-title
  5. Fix type error for context in createPage

@TuvalSimha TuvalSimha changed the title Clean node file and split to small func Make gatsby-node more clear for /code page Mar 7, 2023
@TuvalSimha TuvalSimha marked this pull request as draft March 7, 2023 14:27
@TuvalSimha
fix
f05e819 
Signed-off-by: Tuval Simha <[email protected]>
@TuvalSimha
clean
59dbc18 
Signed-off-by: Tuval Simha <[email protected]>
@TuvalSimha TuvalSimha marked this pull request as ready for review March 20, 2023 14:57
@Urigo
Copy link
Contributor

Urigo commented Mar 20, 2023

I can't seem to be able to trigger the build from Netlify anymore..
@leebyron could you make help?

@Urigo Urigo merged commit 743f359 into graphql:source Apr 4, 2023
@Urigo
Copy link
Contributor

Urigo commented Apr 4, 2023

thanks @TuvalSimha , great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urigo Urigo Urigo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TuvalSimha @Urigo