Skip to content

Conversation

@nuragic
Copy link

@nuragic nuragic commented Jan 12, 2022

Add a link to the mercurius repo (GraphQL server for Fastify).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 12, 2022

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this was the first time I'd heard of it, and the downloads are still pretty small in the npm ecosystem, I don't think we should be calling it out as an explicit recommendation outside of the neautral code section: https://graphql.org/code/#javascript

Copy link
Member

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button

@orta
Copy link
Member

orta commented Jan 19, 2022

I've merged #1162 which added it to the code page, so I'm going to close this PR - thanks for trying to help improve the docs

@orta orta closed this Jan 19, 2022
@nuragic
Copy link
Author

nuragic commented Jan 19, 2022

Hi @orta, thanks! Fair enough 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants