Add spellcheck to test suite #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
added
✏️ Editorial
benjie
approved these changes
Apr 23, 2021
package.json
Outdated
| "test": "spec-md spec/GraphQL.md > /dev/null", | ||
| "test": "npm run test:build && npm run test:spellcheck", | ||
| "test:build": "spec-md spec/GraphQL.md > /dev/null", | ||
| "test:spellcheck": "cspell 'spec/**/*.md'", |
There was a problem hiding this comment.
Might as well spellcheck the README and the RFCs too?
There was a problem hiding this comment.
README yes. RFCs have a zillion spurious errors (like flagging github usernames) so I'll exclude those
|
(My review assumes that you also did a search for the replaced text to ensure nothing escaped; I can't easily do that through the GitHub interface.) |
Yep, I applied the changes manually rather than using any automated replacements to ensure nothing broke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
cspelland an extra word config, adding it to the test suite