Skip to content

Fix/light theme display #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huv1k merged 2 commits into from
Feb 6, 2019
Merged

Fix/light theme display #957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd6ab93
refacotor(react): remove unnecessary css property
yoshiakis Jan 25, 2019
493ed25
fix(react): enable subscription time showed in a light theme
yoshiakis Jan 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/graphql-playground-react/src/components/Playground/Results.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,14 +135,14 @@ const SubscriptionTime = styled.div`
content: '';
top: 9px;
left: 95px;
border-top: 1px solid ${p => p.theme.colours.white20};
border-top: 1px solid
${p => p.theme.editorColours.subscriptionTimeBoaderTop};
}
`

const SubscriptionTimeText = styled.div`
color: rgba(23, 42, 58, 1);
font-size: 12px;
color: rgba(255, 255, 255, 0.5);
color: ${p => p.theme.editorColours.subscriptionTimeText};
padding-left: 15px;
`

Expand Down
6 changes: 6 additions & 0 deletions packages/graphql-playground-react/src/styled/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ export interface EditorColours {
buttonWorkspaceHover: string
buttonWorkspaceText: string
circle: string
subscriptionTimeBoaderTop: string
subscriptionTimeText: string
}

export const darkColours: Colours = {
Expand Down Expand Up @@ -227,6 +229,8 @@ export const darkEditorColours: EditorColours = {
buttonWorkspaceHover: '#a4acb2',
buttonWorkspaceText: 'rgb(23, 42, 58)',
circle: 'rgba(255, 255, 255, 0.4)',
subscriptionTimeBoaderTop: 'rgba(255, 255, 255, 0.2)',
subscriptionTimeText: 'rgba(255, 255, 255, 0.5)',
}

export const lightEditorColours: EditorColours = {
Expand Down Expand Up @@ -283,6 +287,8 @@ export const lightEditorColours: EditorColours = {
buttonWorkspaceHover: 'rgb(157, 166, 173)',
buttonWorkspaceText: 'rgb(238, 239, 240)',
circle: 'rgba(23,42,58,.4)',
subscriptionTimeBoaderTop: 'rgba(23, 42, 58, 0.2)',
subscriptionTimeText: 'rgba(23, 42, 58, 0.5)',
}

export interface Sizes {
Expand Down