Update eslint to the latest version 🚀 #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
leebyron
added a commit
that referenced
this pull request
Feb 9, 2023
This PR implements the tests and fixes necessary for [Spec RFC #987](graphql/graphql-spec#987). This PR is made of three main commits: 1. Test printing a schema that has `Query`, `Mutation` and `Virus` types, but only supports `query` operations (via the `Query` type) and does _not_ support `mutation` operations. 2. Test parsing this same schema text, and assert that the schema does not have a mutation type. 3. Fix the printing of the schema. Co-authored-by: Lee Byron <[email protected]>
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 11, 2025
…3839) This PR implements the tests and fixes necessary for [Spec RFC graphql#987](graphql/graphql-spec#987). This PR is made of three main commits: 1. Test printing a schema that has `Query`, `Mutation` and `Virus` types, but only supports `query` operations (via the `Query` type) and does _not_ support `mutation` operations. 2. Test parsing this same schema text, and assert that the schema does not have a mutation type. 3. Fix the printing of the schema. Co-authored-by: Lee Byron <[email protected]>
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 11, 2025
…3839) This PR implements the tests and fixes necessary for [Spec RFC graphql#987](graphql/graphql-spec#987). This PR is made of three main commits: 1. Test printing a schema that has `Query`, `Mutation` and `Virus` types, but only supports `query` operations (via the `Query` type) and does _not_ support `mutation` operations. 2. Test parsing this same schema text, and assert that the schema does not have a mutation type. 3. Fix the printing of the schema. Co-authored-by: Lee Byron <[email protected]>
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 16, 2025
…3839) This PR implements the tests and fixes necessary for [Spec RFC graphql#987](graphql/graphql-spec#987). This PR is made of three main commits: 1. Test printing a schema that has `Query`, `Mutation` and `Virus` types, but only supports `query` operations (via the `Query` type) and does _not_ support `mutation` operations. 2. Test parsing this same schema text, and assert that the schema does not have a mutation type. 3. Fix the printing of the schema. Co-authored-by: Lee Byron <[email protected]>
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…3839) This PR implements the tests and fixes necessary for [Spec RFC graphql#987](graphql/graphql-spec#987). This PR is made of three main commits: 1. Test printing a schema that has `Query`, `Mutation` and `Virus` types, but only supports `query` operations (via the `Query` type) and does _not_ support `mutation` operations. 2. Test parsing this same schema text, and assert that the schema does not have a mutation type. 3. Fix the printing of the schema. Co-authored-by: Lee Byron <[email protected]>
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…3839) This PR implements the tests and fixes necessary for [Spec RFC graphql#987](graphql/graphql-spec#987). This PR is made of three main commits: 1. Test printing a schema that has `Query`, `Mutation` and `Virus` types, but only supports `query` operations (via the `Query` type) and does _not_ support `mutation` operations. 2. Test parsing this same schema text, and assert that the schema does not have a mutation type. 3. Fix the printing of the schema. Co-authored-by: Lee Byron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.4.1 of eslint just got published.
The version 4.4.1 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
v4.4.1Commits
The new version differs by 3 commits.
0d9da6d4.4.11ea9a6cBuild: changelog update for 4.4.1ec93614Fix: no-multi-spaces to avoid reporting consecutive tabs (fixes #9079) (#9087)See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴