Fix input coercion to allow null-valued Enums as arguments #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add higher level tests, for |
leebyron
reviewed
May 18, 2017
| // null or invalid values represent a failure to parse correctly, | ||
| // in which case no value is returned. | ||
| if (type instanceof GraphQLEnumType ? | ||
| !type.serialize(parsed) : isNullish(parsed)) { |
There was a problem hiding this comment.
Hmm this condition is a little gross now. I wonder if we should instead have something like type.isValidValue() or something along those lines to simplify this?
|
Thanks for this! Always great to see regression tests added. I will look into an improvement to the conditional |
leebyron
added a commit
that referenced
this pull request
May 18, 2017
Used for more semantically correct validity checking after #848
leebyron
added a commit
that referenced
this pull request
May 18, 2017
) Used for more semantically correct validity checking after #848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue pointed out in #840 where null-valued Enums (supported since 0.9.5) were rejected when provided as arguments.
This reveals some minor code duplication in
isValidLiteralValueandvalueFromAST.There are likely other places in the code where null-valued Enums cause problems. To use one example: in
isValidJSValue, if a type isGraphQLNonNull(EnumWithNullValue), thennullshould probably be accepted, since it represents a valid value within the Enum and is thus not reallynull(more generally, it should probably ask theofTypetoserialize()the value first and check to see if that isnull). But I didn't attempt to chase down all those edge cases; these changes are enough to get my test suite passing again.Fixes #840.