Forbid 'true', 'false' and 'null' as names for Enum value #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
force-pushed
the
enumNames
branch
from
0f97e27 to
916c47e
Compare
|
Awesome, thank you! |
|
Um, there is a small grammar mistake in the type definition.
"is" is too much. It might also be better this way
😄 Scott |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Apr 28, 2017
Suggested by @smolinari here: graphql#812 (comment)
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Apr 28, 2017
Suggested by @smolinari here: graphql#812 (comment)
|
@smolinari Thank you. I created separate PR for grammar fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From spec:
+ Move one of test cases into proper location