Merge pull request #812 from APIs-guru/enumNames

Forbid 'true', 'false' and 'null' as names for Enum value

Author: leebyron

src/type/__tests__/validation-test.js

@@ -1188,6 +1188,43 @@ describe('Type System: Enum types must be well defined', () => {
     );
   });
 
+  it('rejects an Enum type with incorrectly named values', () => {
+    function enumValue(name) {
+      return new GraphQLEnumType({
+        name: 'SomeEnum',
+        values: {
+          [name]: {}
+        }
+      });
+    }
+
+    expect(() => enumValue('#value')
+    ).to.throw('Names must match /^[_a-zA-Z][_a-zA-Z0-9]*$/ but "#value" does not.');
+
+    expect(() => enumValue('true')
+    ).to.throw('Name "true" is can not be used for Enum value.');
+
+    expect(() => enumValue('false')
+    ).to.throw('Name "false" is can not be used for Enum value.');
+
+    expect(() => enumValue('null')
+    ).to.throw('Name "null" is can not be used for Enum value.');
+  });
+
+  it('does not allow isDeprecated without deprecationReason on enum', () => {
+    expect(() =>
+      new GraphQLEnumType({
+        name: 'SomeEnum',
+        values: {
+          value: { isDeprecated: true }
+        }
+      })
+    ).to.throw(
+      'SomeEnum.value should provide "deprecationReason" instead ' +
+      'of "isDeprecated".'
+    );
+  });
+
 });
 
 
@@ -2065,18 +2102,4 @@ describe('Objects must adhere to Interface they implement', () => {
     );
   });
 
-  it('does not allow isDeprecated without deprecationReason on enum', () => {
-    expect(() =>
-      new GraphQLEnumType({
-        name: 'SomeEnum',
-        values: {
-          value: { isDeprecated: true }
-        }
-      })
-    ).to.throw(
-      'SomeEnum.value should provide "deprecationReason" instead ' +
-      'of "isDeprecated".'
-    );
-  });
-
 });

src/type/definition.js

@@ -942,6 +942,11 @@ function defineEnumValues(
   );
   return valueNames.map(valueName => {
     assertValidName(valueName);
+    invariant(
+      [ 'true', 'false', 'null' ].indexOf(valueName) === -1,
+      `Name "${valueName}" is can not be used for Enum value.`
+    );
+
     const value = valueMap[valueName];
     invariant(
       isPlainObj(value),