Skip to content

Conversation

benjie
Copy link
Member

@benjie benjie commented Jun 12, 2024

The publish scripts require the shell to be bash, which despite being the shell I use is not the one that npm version seems to use currently. Fixed by forcing the script to run through bash -c

This will NOT work on Windows. Probably it already didn't.

Copy link

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@benjie benjie merged commit c82609e into 16.x.x Jun 12, 2024
@benjie benjie deleted the publish-script-fix-16 branch June 12, 2024 14:17
benjie added a commit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants