instanceOf: workaround bundler issue with process.env
#3923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #3919 #3920 #3921 Context: #3887 changed code and introced optinal chaining. `globalThis.process?.env.NODE_ENV` is transpiled into ``` (_globalThis$process = globalThis.process) === null || _globalThis$process === void 0 ? void 0 : _globalThis$process.env.NODE_ENV; ``` Bundlers incorrectly replace (probably RegExp) `process.env.NODE_ENV` with `"development"` resulting in: ``` (_globalThis$process = globalThis.process) === null || _globalThis$process === void 0 ? void 0 : _globalThis$"development"; ``` Technically it's not a graphql issue but an issue with bundler but since it caused so much pain in comutinity this is an attempt to fix it within our codebase.
IvanGoncharov
added
the
PR: bug fix 🐞
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
Closed
4 tasks
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Sep 1, 2023
Port of graphql#3923 from v16 to main (v17)
IvanGoncharov
added a commit
that referenced
this pull request
Sep 1, 2023
Port of #3923 from v16 to main (v17)
This was referenced Jul 4, 2024
This was referenced Jul 12, 2024
This was referenced Jul 13, 2024
This was referenced Sep 11, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big shout out to @phryneas, who managed to reproduce this issue and come up with this fix.
Fixes: #3919 #3920 #3921
Context: #3887 changed code and introced optinal chaining.
globalThis.process?.env.NODE_ENVis transpiled intoBundlers incorrectly replace (probably RegExp)
process.env.NODE_ENVwith"development"resulting in:Technically it's not a graphql issue but an issue with bundler but since it caused so much pain in comutinity this is an attempt to fix it within our codebase.