Skip to content

Conversation

yaacovCR
Copy link
Contributor

extracted from #3732

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR requested review from robrichard, elisatrevino and a team and removed request for elisatrevino September 13, 2022 13:11
@yaacovCR yaacovCR added the PR: breaking change 💥 implementation requires increase of "major" version number label Sep 13, 2022
@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for compassionate-pike-271cb3 failed.

Name Link
🔨 Latest commit e1b5d34
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63207e012874a800096c02f5

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 1d34ccd
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6321db6bd036150008a97eb1
😎 Deploy Preview https://deploy-preview-3733--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yaacovCR yaacovCR merged commit 364cd71 into graphql:main Sep 14, 2022
@yaacovCR yaacovCR deleted the no-wrapper branch September 14, 2022 13:53
@glasser
Copy link
Contributor

glasser commented Sep 19, 2022

Personally I liked that the two cases had explicit names that you could use to differentiate them from each other instead of just being "has initialResult or doesn't", but I won't put up too much of a fight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants