Add support for adding description to schema #2419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
spec RFC
leebyron
approved these changes
Jan 31, 2020
| @@ -18,7 +18,19 @@ describe('getIntrospectionQuery', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('include "isRepeatable" field', () => { | |||
| it('include "isRepeatable" field on directives', () => { | |||
There was a problem hiding this comment.
Is this related to the isRepeatable change? Or just piggybacking in more tests?
There was a problem hiding this comment.
@leebyron Thanks for the review 👍
Just copy-pasted tests for isRepeatable as starting point for testing that schema's description is present but forgot to change them.
I wrote a new test and committed them.
IvanGoncharov
force-pushed
the
pr_branch
branch
from
74021d5 to
80cec81
Compare
IvanGoncharov
force-pushed
the
pr_branch
branch
from
80cec81 to
f24cc3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements graphql/graphql-spec#466