Skip to content

buildClientSchema: include standard type only if it is used #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

buildClientSchema: include standard type only if it is used #1809

merged 1 commit into from
May 22, 2019

Conversation

IvanGoncharov
Copy link
Member

To be merged in 15.0.0
Details: 183ff32#r32971387

@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Mar 31, 2019
@IvanGoncharov IvanGoncharov added this to the v15.0.0 milestone Mar 31, 2019
IvanGoncharov referenced this pull request May 21, 2019
@IvanGoncharov
Remove excessive cache inside buildClientSchema (#1677)
183ff32
@IvanGoncharov IvanGoncharov added bug PR: bug fix 🐞 requires increase of "patch" version number and removed PR: breaking change 💥 implementation requires increase of "major" version number bug labels May 22, 2019
@IvanGoncharov IvanGoncharov merged commit ff0afa2 into graphql:master May 22, 2019
@IvanGoncharov
Copy link
Member Author

@abernix Merged as a bug fix 🎉
Big thanks for the investigation 🕵

@IvanGoncharov
Copy link
Member Author

@albertstill Can't release 14.3.1 with this fix until GitHub will fix webhooks:
https://twitter.com/githubstatus/status/1131255005909049345
I will keep you updated.

@IvanGoncharov
Copy link
Member Author

@abernix 14.3.1 📦 is published on NPM 🎉

@abernix
Copy link

abernix commented May 23, 2019

Thank you, @IvanGoncharov!

@IvanGoncharov IvanGoncharov deleted the bildClientSchema_doesNotIncludeAllStdTypes branch June 3, 2019 09:04
@trevor-scheer trevor-scheer mentioned this pull request Jun 17, 2019
Merged
4 tasks
@trevor-scheer trevor-scheer mentioned this pull request Jun 28, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvanGoncharov @abernix