Skip to content

Improve typings for validation functions #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2018
Merged

Improve typings for validation functions #1439

merged 1 commit into from
Jul 31, 2018

Conversation

IvanGoncharov
Copy link
Member

Split out from #1438

@IvanGoncharov
Copy link
Member Author

@mjmahone My idea is to clean up #1438 and merge changes that make sense on its own and we both agree on.

@IvanGoncharov IvanGoncharov requested a review from mjmahone July 31, 2018 13:31
@IvanGoncharov IvanGoncharov merged commit b101bf6 into graphql:master Jul 31, 2018
@mjmahone
Copy link
Contributor

Great, thank you! This one makes obvious sense.

@IvanGoncharov IvanGoncharov deleted the validationCleanup branch August 6, 2018 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmahone mjmahone Awaiting requested review from mjmahone

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanGoncharov @mjmahone @facebook-github-bot