Skip to content

Fix how TypeInfo handles inline fragments without type #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix how TypeInfo handles inline fragments without type #1041

merged 1 commit into from
Nov 30, 2017

Conversation

IvanGoncharov
Copy link
Member

image

Try it

This issue caused because TypeInfo incorrectly handles inline fragments without type condition.
#1027 masked this issue by introducing additional type check but underlying bug in TypeInfo still exists.

@leebyron leebyron merged commit 1f6b64e into graphql:master Nov 30, 2017
@leebyron
Copy link
Contributor

Makes sense to me

@IvanGoncharov IvanGoncharov deleted the typeInfoFragmentFix branch December 14, 2017 18:19
This was referenced Feb 8, 2018
Closed
Merged
@OlegIlyenko OlegIlyenko mentioned this pull request Feb 19, 2018
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanGoncharov @leebyron @facebook-github-bot