Skip to content

Conversation

LegNeato
Copy link
Member

@LegNeato LegNeato commented Jun 8, 2018

Fixes #194.

@LegNeato LegNeato force-pushed the doc_comment_derive branch from d7f80c7 to e30abcd Compare June 8, 2018 01:01
@codecov-io
Copy link

codecov-io commented Jun 8, 2018

Codecov Report

Merging #195 into master will decrease coverage by 0.39%.
The diff coverage is 82.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #195     +/-   ##
=========================================
- Coverage   89.88%   89.49%   -0.4%     
=========================================
  Files          96       96             
  Lines       17442    17827    +385     
=========================================
+ Hits        15678    15954    +276     
- Misses       1764     1873    +109
Impacted Files Coverage Δ
juniper_tests/src/lib.rs 100% <ø> (ø) ⬆️
juniper_codegen/src/derive_input_object.rs 0% <0%> (ø) ⬆️
juniper_codegen/src/derive_enum.rs 0% <0%> (ø) ⬆️
juniper_codegen/src/derive_object.rs 0% <0%> (ø) ⬆️
juniper_tests/src/codegen/derive_enum.rs 100% <100%> (ø) ⬆️
juniper_codegen/src/util.rs 86.6% <82.89%> (+9.86%) ⬆️
juniper_tests/src/codegen/derive_input_object.rs 94.73% <90.32%> (-5.27%) ⬇️
juniper_tests/src/codegen/derive_object.rs 90.78% <92.4%> (+0.98%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e841672...0f77515. Read the comment docs.

@theduke
Copy link
Member

theduke commented Jun 8, 2018

@LegNeato I'll review later today

@LegNeato
Copy link
Member Author

LegNeato commented Jun 8, 2018

I'm going to be camping / offline all weekend so no rush!

@LegNeato LegNeato force-pushed the doc_comment_derive branch from 8e48800 to 0f77515 Compare June 10, 2018 03:52
@LegNeato
Copy link
Member Author

Friendly poke @theduke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants