support extend type Foo
#447
Conversation
|
I apologize for opening PRs with failing checks. The lint check seems to be failing due to code unrelated to this PR. Should I change that code in this PR? |
|
No worries! I'm not working actively on this project anymore, but hopefully someone can do a proper review (can't guarantee I'll be able to). Don't worry about clippy if it's unrelated. |
|
FWIW, the clippy things are fixed in #449. |
This reverts commit e0ca7d9.
This reverts commit 52ee1e3.
|
Apologies for the noisy commits. I've reverted those changes, so now this PR contains only the relevant diffs. |
|
Thanks. I've rebased those commits out so that they're not added-and-removed in the same PR. Could you do the same or allow maintainers to push to the branch? |
|
Oh, it did allow me to do so; the error I saw was about not having permission to push tags. |
mathstuf
left a comment
mathstuf
left a comment
There was a problem hiding this comment.
I've rebased out the manual fixes and squashed commits together so that it all passes CI in one shot.
3 participants
This PR adds support for the object extension syntax (
extend type Foo).Fixes #353
Other extension syntaxes such as interface extensions are not supported yet.