Support fragments in interfaces #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
changed the title
tomhoule
changed the title
tomhoule
force-pushed
the
fragments-in-interfaces
branch
3 times, most recently
from
fec1d6b to
e4d2ff1
Compare
Member
Author
|
@h-michael tagging you in case you want to review this (no obligation of course). |
tomhoule
commented
Sep 29, 2018
| iface.field_impls_for_selection(context, &self.selection, &self.name)?; | ||
| let fields = | ||
| iface.response_fields_for_selection(context, &self.selection, &self.name)?; | ||
| (field_impls, fields) |
Member
Author
There was a problem hiding this comment.
This code isn't pretty, we could make it a trait. On the other hand we have to support type-refining fragments so it may not be the right time to abstract more.
| type InterfaceQuery { | ||
| everything: [Named!] | ||
| everything: [Named!] | ||
| } |
Member
Author
There was a problem hiding this comment.
Weird, I wonder if it's .editorconfig.
tomhoule
force-pushed
the
fragments-in-interfaces
branch
2 times, most recently
from
4ab0429 to
2b1ce4f
Compare
This is limited to the interface’s own fields for now. We do not support type-refining fragments (see this issue: #154).
It fixes a panic on previous versions in some cases when multiple fields in a struct are marked with #[flatten]. We do that in interfaces.
Also enable #[deny(missing_docs)] on the codegen crate.
tomhoule
force-pushed
the
fragments-in-interfaces
branch
from
2b1ce4f to
a05f0b5
Compare
h-michael
approved these changes
Sep 30, 2018
Member
Author
|
Great, thanks :) It's the last thing I wanted in for the 0.5 release, so it's happening soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.