Skip to content

Remove references to executor in Flask view #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2020
Merged

Remove references to executor in Flask view #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions graphql_server/flask/graphqlview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

class GraphQLView(View):
schema = None
executor = None
root_value = None
pretty = False
graphiql = False
Expand Down Expand Up @@ -51,9 +50,6 @@ def get_context_value(self):
def get_middleware(self):
return self.middleware

def get_executor(self):
return self.executor

def render_graphiql(self, params, result):
return render_graphiql(
params=params,
Expand All @@ -76,13 +72,6 @@ def dispatch_request(self):

pretty = self.pretty or show_graphiql or request.args.get("pretty")

extra_options = {}
executor = self.get_executor()
if executor:
# We only include it optionally since
# executor is not a valid argument in all backends
extra_options["executor"] = executor

execution_results, all_params = run_http_query(
self.schema,
request_method,
Expand All @@ -94,7 +83,6 @@ def dispatch_request(self):
root_value=self.get_root_value(),
context_value=self.get_context_value(),
middleware=self.get_middleware(),
**extra_options
)
result, status_code = encode_execution_results(
execution_results,
Expand Down