Skip to content

Replaced sys.excepthook with logging.error #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Replaced sys.excepthook with logging.error #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions graphql/execution/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# -*- coding: utf-8 -*-
import sys
import logging
from traceback import format_exception

from ..error import GraphQLError
from ..language import ast
Expand All @@ -11,6 +12,8 @@
from ..utils.type_from_ast import type_from_ast
from .values import get_argument_values, get_variable_values

logger = logging.getLogger(__name__)


class ExecutionContext(object):
"""Data that must be available at all points during query execution.
Expand Down Expand Up @@ -87,8 +90,8 @@ def get_argument_values(self, field_def, field_ast):
return result

def report_error(self, error, traceback=None):
sys.excepthook(type(error), error, getattr(
error, 'stack', None) or traceback)
exception = format_exception(type(error), error, getattr(error, 'stack', None) or traceback)
logger.error(''.join(exception))
self.errors.append(error)

def get_sub_fields(self, return_type, field_asts):
Expand Down