-
Notifications
You must be signed in to change notification settings - Fork 181
Enum default_value serialization issue #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Any progress?? |
I haven't tried looking through the source again to try to figure it out. I just stopped using default_value for enums. Which sucks but not currently critical for my projects. I hope this issue can get some love from someone |
I'm also affected by this. Using default values with Enums currently breaks introspection with our client library (in our case we use Apollo). Is there a suggested work around for this? |
@MichaelAquilina I would give it a default value in the resolver, input.get('my_enum', MyEnum.FOO.value) |
Originally reported in graphene issue #691
Argument default_value serializes enum value instead of name. graphql spec does not support enum values and graphql-js serializes enums to the name not value. graphql-python is not consistent with graphql-js. I attempted to find a workaround by setting the enum value to a string of the name but teh result is a string that includes escaped quotes.
Using the name of the enum doesn't work:
This results in the defaultValue being
"\"FOO\""
. This does not follow the graphql spec for enums and breaks with third party introspection. Specifically i'm trying to stitch a graphene remote schema and the invalid defaultValue results in a null returned in the merged schema (using graphql-tools).Using a string value doesn't work either:
This also doesn't work with using MyEnum.FOO.value for default_value nor setting it specifically to the static string "FOO".
I tried looking for how default_value gets resolved for enums but haven't been able to track it down. I think if we can just get the string value for default_value to not include the escaped string quotes then my schema stitching will work. I haven't been able to figure out how to define an enum so that this will happen.
The text was updated successfully, but these errors were encountered: