Feat: make new filters feature optional #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikwrede
approved these changes
Sep 13, 2024
Member
erikwrede
left a comment
erikwrede
left a comment
There was a problem hiding this comment.
that definitely was an oversight. Thanks for fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have developed our own filtering system on top of
graphene-sqlalchemypreviously and have no need for automatic generation of filters on connections and the currently only clutter up our schema. I haven't found a way to disable them in docs, however, after walking through the code, it seemed to me that the option is there - it's just hardcoded to be alwaysTrue. Was there a reason for that, or maybe an oversight?This is my first time opening a public pull request, so I'm open to feedback and pointers! Thanks a lot for your work!