Skip to content

Start raising DeprecationWarnings for using only_fields and exclude_fields (v3) #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Start raising DeprecationWarnings for using only_fields and exclude_fields (v3) #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions graphene_django/tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def inner(*args, **kwargs):

@with_local_registry
def test_django_objecttype_only_fields():
with pytest.warns(PendingDeprecationWarning):
with pytest.warns(DeprecationWarning):

class Reporter(DjangoObjectType):
class Meta:
Expand Down Expand Up @@ -347,7 +347,7 @@ class Meta:

@with_local_registry
def test_django_objecttype_exclude_fields():
with pytest.warns(PendingDeprecationWarning):
with pytest.warns(DeprecationWarning):

class Reporter(DjangoObjectType):
class Meta:
Expand Down
4 changes: 2 additions & 2 deletions graphene_django/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def __init_subclass_with_meta__(
if only_fields:
warnings.warn(
"Defining `only_fields` is deprecated in favour of `fields`.",
PendingDeprecationWarning,
DeprecationWarning,
stacklevel=2,
)
fields = only_fields
Expand All @@ -210,7 +210,7 @@ def __init_subclass_with_meta__(
if exclude_fields:
warnings.warn(
"Defining `exclude_fields` is deprecated in favour of `exclude`.",
PendingDeprecationWarning,
DeprecationWarning,
stacklevel=2,
)
exclude = exclude_fields
Expand Down