Support required=True for DjangoFilterConnectionFields
#711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbyte64
requested changes
Jul 19, 2019
Collaborator
zbyte64
left a comment
zbyte64
left a comment
There was a problem hiding this comment.
Would like to see a test cover what happens when they don't request a required connection field.
| pytestmark = pytest.mark.django_db | ||
|
|
||
|
|
||
| def test_required_connection_field(): |
Collaborator
There was a problem hiding this comment.
What is the difference between this test and test_required_filter_field ?
Member
Author
There was a problem hiding this comment.
@zbyte64 this test uses a DjangoConnectionField while the other test uses a DjangoFilterConnectionField
Member
Author
|
Looks like this got fixed in #610 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700