-
Notifications
You must be signed in to change notification settings - Fork 767
Support use first
and last
at same time as offset
#563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
According to coveralls there are 3 new conditions not tested:
We should have tests for those. |
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes and clarifications would be great. Otherwise I think this looks good. Thanks for the contribution, it's great to see more strictness and good error messages.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ping @danpalmer |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I am closing this PR because my project has been rewritten in golang. |
@NateScarlet, Sorry to bring this thread back to life. But would you help me with the reason why you re wrote your project in Go Lang? |
I switch to golang because it has better performance on same hardware. I am using gqlgen |
Current implementation of max limit not correct when use
first
andlast
at same timeThis operation is only valid when
graphene_settings.RELAY_CONNECTION_MAX_LIMIT
greater than 9999:Fixed it by using
count = min(i for i in (first, last) if i)