Support use first and last at same time as offset
#1022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpict
changed the title
first and last at same time as offset
tpict
force-pushed
the
connection-offset
branch
from
cb5b2ad to
0bf77c0
Compare
tpict
force-pushed
the
connection-offset
branch
from
0bf77c0 to
1eee5a4
Compare
tpict
force-pushed
the
connection-offset
branch
from
615e43a to
78ff452
Compare
tpict
force-pushed
the
connection-offset
branch
from
78ff452 to
3da80b5
Compare
|
Is this still relevant after #1013 getting merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @NateScarlet's work on #563. I can take over the PR since it's already had reviews and I think it's a very common use case. I'm not sure what the overlap with #1013 is.
Fixes #809