Skip to content

Document Django Debug types #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2018
Merged

Conversation

danpalmer
Copy link
Collaborator

@danpalmer danpalmer commented Sep 9, 2018

This adds documentation for the debug fields/types in Graphene-Django.

Included in this is more strictness in whether some of the fields are required, as that is an important form of documentation in itself. These were determined from reading the source for NormalCursorWrapper._record, and some of the Django functions/methods that back that, but please do review as I might have missed something.

@coveralls
Copy link

coveralls commented Sep 9, 2018

Coverage Status

Coverage increased (+0.01%) to 94.597% when pulling 040f6aa on danpalmer:patch-2 into f4bbae2 on graphql-python:master.

@danpalmer
Copy link
Collaborator Author

@syrusakbary I think this is all ready to go. Hopefully an uncontroversial change.

@syrusakbary syrusakbary merged commit 3d493c3 into graphql-python:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants