Skip to content

Improve ErrorType #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2018
Merged

Improve ErrorType #382

merged 1 commit into from
Feb 4, 2018

Conversation

patrick91
Copy link
Member

Marks some fields as required and non null, it also prevents to do useless checks on the frontend if using a typed language.

Example:
screen shot 2018-01-23 at 16 17 55

@coveralls
Copy link

coveralls commented Jan 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 93.575% when pulling 6a15282 on patrick91:patch-1 into 53546a2 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.575% when pulling 57195ae on patrick91:patch-1 into e05f069 on graphql-python:master.

@patrick91
Improve ErrorType
6a15282 
Marks some fields as required and non null, it also prevents to do useless checks on the frontend if using a typed language.
@patrick91
Copy link
Member Author

This is ready to be merged @syrusakbary

@syrusakbary syrusakbary merged commit c585982 into graphql-python:master Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick91 @coveralls @syrusakbary