Skip to content

Fixed FilterConnectionFields with limit in the FilterSet #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 15, 2017
Merged

Fixed FilterConnectionFields with limit in the FilterSet #151

merged 12 commits into from
Apr 15, 2017

Conversation

syrusakbary
Copy link
Member

Improved #126 tests, by chaining the querysets and mixing the limits.

@coveralls
Copy link

coveralls commented Apr 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 93.936% when pulling dbf0069 on fix-filter-and-resolver into 005bb7f on master.

@coveralls
Copy link

coveralls commented Apr 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 93.936% when pulling dbf0069 on fix-filter-and-resolver into 005bb7f on master.

@syrusakbary syrusakbary merged commit 3803e9a into master Apr 15, 2017
@tillkolter
Copy link

@syrusakbary I found out that merge_queryset (or better QuerySet.__add__) is cleaning extra/annotated fields. My resolver query is rather complex and need that annotated column for sorting.

@dvdmgl dvdmgl mentioned this pull request Jun 5, 2017
Closed
@syrusakbary syrusakbary deleted the fix-filter-and-resolver branch September 1, 2017 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syrusakbary @coveralls @tillkolter