Skip to content

[WIP] Fixes DjangoFilterConnectionField filter slices being ignored with a custom resolver #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 15, 2017
Merged

[WIP] Fixes DjangoFilterConnectionField filter slices being ignored with a custom resolver #126

merged 7 commits into from
Apr 15, 2017

Conversation

NiallBrickell
Copy link

@NiallBrickell NiallBrickell commented Mar 5, 2017 •
edited
Loading

TODO:

  • Fix tests

@NiallBrickell NiallBrickell changed the title Fixes DjangoFilterConnectionField filter slices being ignored with a custom resolver [WIP] Fixes DjangoFilterConnectionField filter slices being ignored with a custom resolver Mar 5, 2017
@NiallBrickell
Copy link
Author

Breaks multiple filters filtering. Will find another solution.

@NiallBrickell NiallBrickell mentioned this pull request Mar 6, 2017
Closed
@NiallBrickell NiallBrickell force-pushed the fix-filter-and-resolver branch from ccd855a to fda876f Compare March 6, 2017 19:41
@NiallBrickell
Copy link
Author

@syrusakbary two tests are failing and I don't know enough about the repo to fix them: test_should_query_connection and test_should_query_connectionfilter in graphene_django/debug/tests/test_query.py. Looks like COUNT is missing from the SQL.

Would you mind taking a look?

@NiallBrickell
Copy link
Author

Breaks .order_by in the resolver. Pushed an example broken test in 2117cb2.

@syrusakbary
Copy link
Member

Sorry for taking so long to review, taking a look now :)

@syrusakbary syrusakbary mentioned this pull request Apr 15, 2017
Merged
@syrusakbary syrusakbary merged commit 2117cb2 into graphql-python:master Apr 15, 2017
@NiallBrickell
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiallBrickell @syrusakbary