Update requirements to the official graphene 3.0 release #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, Graphql-relay introduces breaking changes to this repo in version 3.1.1 Use stricter pinning of the graphene and graphql-relay requirements in support of this upgrade as graphene 3.0 supports 3.0-4.0 which is too broad for graphene-django
ulgens
approved these changes
Jan 22, 2022
jkimbo
approved these changes
Jan 22, 2022
|
@keithhackbarth Looks like the tests are failing though |
keithhackbarth
force-pushed
the
graphql_relay_pin_version
branch
from
ead1995 to
e996514
Compare
|
Thanks, @jkimbo - I think there may be a fragility issue with our CI as I just re-ran the tests on the exact same code and they passed this time. I can try to investigate and look into it in a separate PR. This one should be good to merge now! |
|
Ok thanks @keithhackbarth |
|
@jkimbo Any chance a new release can be pushed to PyPI? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, Graphql-relay introduces breaking changes to this repo in version 3.1.1, so I used stricter pinning of the graphene and graphql-relay requirements and switching to
arrray_connectionin support of this upgrade; graphene 3.0 supports 3.0-4.0 which is too broad for graphene-django.