Skip to content

Only override non declared filters #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Only override non declared filters #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a107c29
only override declared filters with in lookup
DonQueso89 Jan 29, 2021
c191b78
upd tests
DonQueso89 Jan 29, 2021
3e11ae0
format
DonQueso89 Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions graphene_django/filter/tests/test_in_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,7 @@ class Meta:
class PersonFilterSet(FilterSet):
class Meta:
model = Person
fields = {}

names = filters.BaseInFilter(method="filter_names")

def filter_names(self, qs, name, value):
return qs.filter(name__in=value)
fields = {"name": ["in"]}


class PersonNode(DjangoObjectType):
Expand Down Expand Up @@ -92,7 +87,7 @@ def test_string_in_filter_with_filterset_class():

query = """
query {
people (names: ["John", "Michael"]) {
people (name_In: ["John", "Michael"]) {
edges {
node {
name
Expand Down
2 changes: 2 additions & 0 deletions graphene_django/filter/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ def replace_csv_filters(filterset_class):
"""
for name, filter_field in list(filterset_class.base_filters.items()):
filter_type = filter_field.lookup_expr
if name in filterset_class.declared_filters:
continue
if filter_type in {"in", "contains", "overlap"}:
filterset_class.base_filters[name] = InFilter(
field_name=filter_field.field_name,
Expand Down