Native DataLoader dispatch strategy without Instrumentation #3447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andimarek
changed the title
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
src/main/java/graphql/execution/DataLoaderDispatchStrategy.java
Outdated
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
src/main/java/graphql/execution/DataLoaderDispatchStrategy.java
Outdated
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java
Outdated
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
.../graphql/execution/instrumentation/dataloader/DataLoaderDispatcherInstrumentationTest.groovy
Outdated
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
.../graphql/execution/instrumentation/dataloader/DataLoaderDispatcherInstrumentationTest.groovy
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
src/test/groovy/graphql/execution/instrumentation/dataloader/DataLoaderTypeMismatchTest.groovy
Outdated
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
...t/groovy/graphql/execution/instrumentation/dataloader/Issue1178DataLoaderDispatchTest.groovy
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
...graphql/execution/instrumentation/dataloader/PeopleCompaniesAndProductsDataLoaderTest.groovy
Show resolved
Hide resolved
bbakerman
reviewed
Feb 16, 2024
bbakerman
reviewed
Feb 16, 2024
...in/java/graphql/execution/instrumentation/dataloader/PerLevelDataLoaderDispatchStrategy.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement the DataLoader dispatch strategy as a native implementation without the usage of Instrumentation.
If you are using the automatic DataLoader dispatching provided by the
DataLoaderDispatcherInstrumentationyou don't need to do anything: the behaviour is exactly the same.Breaking change details
This is a breaking change as it removes the
DataLoaderDispatcherInstrumentation(and related classes) and the related methodGraphQL.doNotAddDefaultInstrumenation.If a user doesn't want to use the build in dispatching they can opt out with
GraphQL.doNotAutomaticallyDispatchDataLoader.