Fix ChainInstrumentation misses to pass down calls chained contexts causes hanging #1090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
ChainedInstrumentation
along with theDataLoaderInstrumentation
any GraphQL query containing lists of lists will hang indefinitely. The reason is, the chained instrumentation is not correctly passing calls back to the chained contexts, which will cause to never trigger dispatches. For reference this is the offending line/commitSteps to reproduce
I reused the
DataLoaderPerformanceTest
but instead with aChainedInstrumentation
to reproduce the issue/hanging.Note the use of
ChainedInstrumentation
below.Fix & Testing
I created custom
InstrumentationContext
s that overrideonFieldValuesInfo
andonDeferredField
,onFieldValueInfo
respectively and passed down the calls to the instrumentations.Regarding the tests, I did not want to parameterize every single existing test (using spock
where:
) inside theDataLoaderPerformanceTest
specification as I believe would increase the already cognitive load of these tests. Instead, I duplicated them and I separated them while extracting the common logic. Let me know if that's ok.