Skip to content

Allowing nested inputs defined in extensions to be parsed as well #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2021
Merged

Allowing nested inputs defined in extensions to be parsed as well #480

merged 2 commits into from
Feb 16, 2021

Conversation

thomasw21
Copy link
Contributor

@thomasw21 thomasw21 commented Feb 15, 2021 •
edited
Loading

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

Fields declared in extension would not be parsed, this PR fixes that issue with corresponding UT.

oryan-block
oryan-block requested changes Feb 16, 2021
View reviewed changes
Copy link
Collaborator

@oryan-block oryan-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a minor cleanup.

oryan-block
oryan-block approved these changes Feb 16, 2021
View reviewed changes
Copy link
Collaborator

@oryan-block oryan-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me.

@vojtapol vojtapol merged commit cfd4de2 into graphql-java-kickstart:master Feb 16, 2021
@thomasw21 thomasw21 deleted the nested_inputs_in_extensions_do_not_work branch February 16, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtapol vojtapol vojtapol approved these changes

@oryan-block oryan-block oryan-block approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasw21 @vojtapol @oryan-block