Skip to content

consider making servlet api's provided by server #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eduarddrenth opened this issue Dec 5, 2022 · 0 comments · Fixed by #520
Closed

consider making servlet api's provided by server #490

eduarddrenth opened this issue Dec 5, 2022 · 0 comments · Fixed by #520
Milestone

Comments

@eduarddrenth
Copy link
Contributor

graphql-java-servlet now has a compile dependency on servlet api's. Normally these api's will be server provided.

of course user can exclude like below, but I think it would be good to add <scope>provided<scope>.

            <exclusions>
                <exclusion>
                    <groupId>jakarta.servlet</groupId>
                    <artifactId>jakarta.servlet-api</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>jakarta.websocket</groupId>
                    <artifactId>jakarta.websocket-api</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>jakarta.websocket</groupId>
                    <artifactId>jakarta.websocket-client-api</artifactId>
                </exclusion>
            </exclusions>
oliemansm added a commit that referenced this issue May 10, 2023
@oliemansm oliemansm added this to the 15.1.0 milestone May 10, 2023
oliemansm added a commit that referenced this issue May 10, 2023
fixes #490

(cherry picked from commit ebbd814)
federicorispo pushed a commit to federicorispo/graphql-java-servlet that referenced this issue May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants