Skip to content

Conversation

theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Oct 9, 2025

🤖 New release

  • hive-router-config: 0.0.6 -> 0.0.7 (✓ API compatible changes)
  • hive-router-plan-executor: 3.0.0 -> 4.0.0 (⚠ API breaking changes)
  • hive-router: 0.0.11 -> 0.0.12 (✓ API compatible changes)

hive-router-plan-executor breaking changes

--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field HTTPSubgraphExecutor.subgraph_name in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/http.rs:32
  field QueryPlanExecutionContext.jwt_auth_forwarding in /tmp/.tmpiyqlFo/router/lib/executor/src/execution/plan.rs:75
  field HttpExecutionRequest.extensions in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/common.rs:36

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/enum_variant_added.ron

Failed in:
  variant SubgraphExecutorError:EndpointExpressionBuild in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/error.rs:10
  variant SubgraphExecutorError:EndpointExpressionResolutionFailure in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/error.rs:12
  variant SubgraphExecutorError:EndpointExpressionWrongType in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/error.rs:14
  variant SubgraphExecutorError:StaticEndpointNotFound in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/error.rs:16

--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/function_parameter_count_changed.ron

Failed in:
  hive_router_plan_executor::utils::traverse::traverse_and_callback_mut now takes 5 parameters instead of 4, in /tmp/.tmpiyqlFo/router/lib/executor/src/utils/traverse.rs:9

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/inherent_method_missing.ron

Failed in:
  SubgraphExecutorMap::insert_boxed_arc, previously in file /tmp/.tmp3WP7QE/hive-router-plan-executor/src/executors/map.rs:71
  SubgraphExecutorMap::insert_boxed_arc, previously in file /tmp/.tmp3WP7QE/hive-router-plan-executor/src/executors/map.rs:71

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.43.0/src/lints/method_parameter_count_changed.ron

Failed in:
  hive_router_plan_executor::execution::plan::Executor::new now takes 7 parameters instead of 6, in /tmp/.tmpiyqlFo/router/lib/executor/src/execution/plan.rs:225
  hive_router_plan_executor::context::ExecutionContext::handle_errors now takes 4 parameters instead of 2, in /tmp/.tmpiyqlFo/router/lib/executor/src/context.rs:45
  hive_router_plan_executor::executors::map::SubgraphExecutorMap::new now takes 1 parameters instead of 0, in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/map.rs:66
  hive_router_plan_executor::executors::map::SubgraphExecutorMap::execute now takes 4 parameters instead of 3, in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/map.rs:118
  hive_router_plan_executor::SubgraphExecutorMap::new now takes 1 parameters instead of 0, in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/map.rs:66
  hive_router_plan_executor::SubgraphExecutorMap::execute now takes 4 parameters instead of 3, in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/map.rs:118
  hive_router_plan_executor::executors::http::HTTPSubgraphExecutor::new now takes 6 parameters instead of 5, in /tmp/.tmpiyqlFo/router/lib/executor/src/executors/http.rs:47
Changelog

hive-router-config

0.0.7 - 2025-10-16

Added

  • (router) Subgraph endpoint overrides (#488)
  • (router) jwt auth (#455)
  • (router) CORS support (#473)
  • (router) CSRF prevention for browser requests (#472)

Fixed

  • (router) improve csrf and other configs (#487)

hive-router-plan-executor

4.0.0 - 2025-10-16

Added

  • (router) Subgraph endpoint overrides (#488)
  • (router) jwt auth (#455)
  • (executor) include subgraph name and code to the errors (#477)
  • (executor) normalize flatten errors for the final response (#454)

Fixed

  • (router) allow null value for nullable scalar types while validating variables (#483)
  • (router) fix graphiql autocompletion, and avoid serializing nulls for optional extension fields (#485)

hive-router

0.0.12 - 2025-10-16

Added

  • (router) Subgraph endpoint overrides (#488)
  • (router) jwt auth (#455)
  • (router) CORS support (#473)
  • (router) CSRF prevention for browser requests (#472)
  • (executor) include subgraph name and code to the errors (#477)
  • (executor) normalize flatten errors for the final response (#454)

Fixed

  • (router) fix graphiql autocompletion, and avoid serializing nulls for optional extension fields (#485)
  • (router) improve csrf and other configs (#487)
  • (router) allow null value for nullable scalar types while validating variables (#483)


This PR was generated with release-plz.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine release for two key components: hive-router-plan-executor and hive-router. The hive-router-plan-executor module receives a major version bump due to necessary API breaking changes, primarily concerning function and method parameter counts. Concurrently, hive-router undergoes a minor version update. Both releases integrate an enhancement focused on standardizing the format of flattened errors in responses, aiming for more consistent error handling.

Highlights

  • Major Version Update for hive-router-plan-executor: The hive-router-plan-executor package has been updated from version 3.0.0 to 4.0.0, indicating significant API breaking changes.
  • Minor Version Update for hive-router: The hive-router package has been updated from version 0.0.11 to 0.0.12, which includes API compatible changes.
  • Breaking Changes Detailed: The breaking changes in hive-router-plan-executor specifically involve changes in parameter counts for the traverse_and_callback_mut function (from 4 to 5 parameters) and the ExecutionContext::handle_errors method (from 2 to 3 parameters).
  • Error Normalization Feature: Both updated packages now include functionality to 'normalize flatten errors for the final response', as referenced in PR feat(executor): normalize flatten errors for the final response #454.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by release-plz, correctly bumps the versions of hive-router-plan-executor to 4.0.0 and hive-router to 0.0.12. The changes in Cargo.toml, Cargo.lock, and the changelogs are consistent with the release. I've added one suggestion to improve the changelog for hive-router-plan-executor to make the breaking changes more explicit for consumers of the library.

Comment on lines 12 to 17
### Added

- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since version 4.0.0 is a major release with breaking API changes, it's helpful to explicitly list them in the changelog. This provides better visibility for developers and helps prevent issues during upgrades. I'd suggest adding a Changed section to highlight these breaking changes.

Suggested change
### Added
- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454))
### Changed
- **BREAKING**: The function signatures for traverse_and_callback_mut and ExecutionContext::handle_errors have been updated.
### Added
- *(executor)* normalize flatten errors for the final response ([#454](https://github.com/graphql-hive/router/pull/454))

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

k6-benchmark results

     ✓ response code was 200
     ✓ no graphql errors
     ✓ valid response structure

     █ setup

     checks.........................: 100.00% ✓ 219855      ✗ 0    
     data_received..................: 6.4 GB  214 MB/s
     data_sent......................: 86 MB   2.9 MB/s
     http_req_blocked...............: avg=3.58µs  min=721ns   med=1.77µs  max=7.38ms   p(90)=2.48µs   p(95)=2.84µs  
     http_req_connecting............: avg=722ns   min=0s      med=0s      max=2.16ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=19.98ms min=2.14ms  med=19.18ms max=104.51ms p(90)=27.02ms  p(95)=29.9ms  
       { expected_response:true }...: avg=19.98ms min=2.14ms  med=19.18ms max=104.51ms p(90)=27.02ms  p(95)=29.9ms  
     http_req_failed................: 0.00%   ✓ 0           ✗ 73305
     http_req_receiving.............: avg=153µs   min=24.88µs med=39.49µs max=71.3ms   p(90)=102.42µs p(95)=417.06µs
     http_req_sending...............: avg=24.46µs min=5.75µs  med=10.87µs max=19.68ms  p(90)=16.69µs  p(95)=30.03µs 
     http_req_tls_handshaking.......: avg=0s      min=0s      med=0s      max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=19.81ms min=2.09ms  med=19.04ms max=51.48ms  p(90)=26.78ms  p(95)=29.62ms 
     http_reqs......................: 73305   2437.606587/s
     iteration_duration.............: avg=20.46ms min=6.23ms  med=19.55ms max=240.01ms p(90)=27.47ms  p(95)=30.41ms 
     iterations.....................: 73285   2436.941528/s
     vus............................: 50      min=50        max=50 
     vus_max........................: 50      min=50        max=50 

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

🐋 This PR was built and pushed to the following Docker images:

Image Names: ghcr.io/graphql-hive/router

Platforms: linux/amd64,linux/arm64

Image Tags: ghcr.io/graphql-hive/router:pr-476 ghcr.io/graphql-hive/router:sha-b985076

Docker metadata
{
"buildx.build.ref": "builder-bde5bbe3-55a8-495b-932f-8cfd81eb9c51/builder-bde5bbe3-55a8-495b-932f-8cfd81eb9c510/y6um4wp2724w7fcf903lyly31",
"containerimage.descriptor": {
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "digest": "sha256:3001958966ca3b6fe8bea91c94d4d57494e488ff7cc6aacf2644a9ee4247fb7c",
  "size": 1609
},
"containerimage.digest": "sha256:3001958966ca3b6fe8bea91c94d4d57494e488ff7cc6aacf2644a9ee4247fb7c",
"image.name": "ghcr.io/graphql-hive/router:pr-476,ghcr.io/graphql-hive/router:sha-b985076"
}

@theguild-bot theguild-bot force-pushed the release-plz-2025-10-09T12-46-08Z branch 11 times, most recently from f890ef3 to 842f213 Compare October 16, 2025 09:42
@theguild-bot theguild-bot force-pushed the release-plz-2025-10-09T12-46-08Z branch from 842f213 to de83e3e Compare October 16, 2025 13:02
@dotansimha dotansimha merged commit 01a68a9 into main Oct 19, 2025
18 checks passed
@dotansimha dotansimha deleted the release-plz-2025-10-09T12-46-08Z branch October 19, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants