Skip to content

Conversation

@EmrysMyrddin
Copy link
Contributor

@EmrysMyrddin EmrysMyrddin commented Dec 18, 2020

This is PR aims to extends compatibility of this plugin with eslint ecosystem

Related #88

This proposal comes from #88 (comment) @lavigneer's comment.

The workaround plays with relative path in the block filename containing original source text. It allows other plugins to resolve original source file on the filesystem.

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2020

🦋 Changeset detected

Latest commit: 89fc798

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphql-eslint/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@EmrysMyrddin EmrysMyrddin force-pushed the preprocessor-workaround branch from eaaa824 to 1f911ad Compare December 19, 2020 11:04
@EmrysMyrddin EmrysMyrddin force-pushed the preprocessor-workaround branch from 1f911ad to 67525cd Compare December 19, 2020 11:05
@dotansimha
Copy link
Member

This is awesome, thank you @EmrysMyrddin . I triggered CI (#228) to release alpha version: @graphql-eslint/[email protected]. I'm trying it now :)

@dotansimha
Copy link
Member

I can confirm it's working. Thank you so much @EmrysMyrddin ! Will release soon.

@dotansimha dotansimha merged commit 937b322 into graphql-hive:master Dec 19, 2020
@JounQin
Copy link
Contributor

JounQin commented Apr 22, 2021

There is no need to use this hacky way, see my new PR at #394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants