Skip to content

Conversation

henryqdineen
Copy link
Contributor

@henryqdineen henryqdineen commented Nov 18, 2020

Related #75, which we also ran into.

This PR updates the input-name rule so it will ignore any fields that aren't on the Mutation type. This assumes that the schema is using the default Mutation type name. If we want to support a custom mutation type name we could add it as an option or alternatively parse for the schema { mutation: MyMutationRootType }

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2020

🦋 Changeset detected

Latest commit: 85d98bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-eslint/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha
Copy link
Member

dotansimha commented Nov 18, 2020

Awesome catch, thank you @henryqdineen !
Can you please add a changeset for that change? (run yarn changeset and it will guide you, please bump patch)

@henryqdineen
Copy link
Contributor Author

Thanks @dotansimha. I just pushed the changeset.

@dotansimha
Copy link
Member

Awesome, thank you. Merging, and will release right after!

@dotansimha dotansimha merged commit 0fe0f68 into graphql-hive:master Nov 18, 2020
@henryqdineen henryqdineen deleted the hqd-input-name branch November 18, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants