Skip to content

Equals sign in union is optional according to spec #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Equals sign in union is optional according to spec #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions language/parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,7 +1191,7 @@ func parseInterfaceTypeDefinition(parser *Parser) (ast.Node, error) {
}

/**
* UnionTypeDefinition : Description? union Name Directives? = UnionMembers
* UnionTypeDefinition : Description? union Name Directives? UnionMembers?
*/
func parseUnionTypeDefinition(parser *Parser) (ast.Node, error) {
start := parser.Token.Start
Expand All @@ -1211,13 +1211,16 @@ func parseUnionTypeDefinition(parser *Parser) (ast.Node, error) {
if err != nil {
return nil, err
}
_, err = expect(parser, lexer.EQUALS)
if err != nil {
return nil, err
}
types, err := parseUnionMembers(parser)
if err != nil {
return nil, err
var types []*ast.Named
if parser.Token.Kind == lexer.EQUALS {
err = advance(parser)
if err != nil {
return nil, err
}
types, err = parseUnionMembers(parser)
if err != nil {
return nil, err
}
}
return ast.NewUnionDefinition(&ast.UnionDefinition{
Name: name,
Expand All @@ -1229,9 +1232,11 @@ func parseUnionTypeDefinition(parser *Parser) (ast.Node, error) {
}

/**
* UnionMembers :
* UnionMembers : = UnionMemberTypes
*
* UnionMemberTypes
* - NamedType
* - UnionMembers | NamedType
* - UnionMemberTypes | NamedType
*/
func parseUnionMembers(parser *Parser) ([]*ast.Named, error) {
members := []*ast.Named{}
Expand Down