Emit descriptions as block strings in printer.Print
#485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhoriuchi
approved these changes
Jul 5, 2019
Contributor
Author
|
@bhoriuchi are y'all waiting for a release...? |
Contributor
|
@mmmveggies I don’t have write access on this project to my knowledge. Just a contributor like you. |
|
Does anyone know if this fix will get added into the code soon? |
|
Anyone with the write access? |
chris-ramon
approved these changes
Apr 26, 2020
Member
chris-ramon
left a comment
chris-ramon
left a comment
There was a problem hiding this comment.
LGTM 👍 –– Thanks a lot @mmmveggies 💯 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484
Adds description printing to the
printer.Printmethod, with tests to verify.Seeks to keep field/directive arguments inline if none among all siblings have a description.