AWS AppSync Support #287
AWS AppSync Support #287
Conversation
| throw; | ||
| } | ||
|
|
||
| // TODO: wait for "connection_ack" response |
There was a problem hiding this comment.
Technically, the client should be waiting for the connection_ack response before proceeding. For now, I put a TODO comment here as I don't have the experience with RX to know how to properly codify this step.
There was a problem hiding this comment.
In the Apollo GraphQL over WebSocket Protocol description they write that the server may respond with GQL_CONNECTION_ACK... so it might be better to not wait for it?
But it also might resolve the unpredictable tests problem...
There was a problem hiding this comment.
Urgh... may is the worst.
|
Here a sample Blazor app built with these changes: https://github.com/bjorg/GraphQlAppSyncTest/blob/main/MyApp/Pages/Index.razor Using the new subscription pre-processor, I was able create a fairly simple adapter to configure GraphQL.Client for AppSync: |
|
@rose-a Do you have any feedback on these changes? |
|
@bjorg Sorry, I did not yet find time to review your work, I hope I'll manage sometime this week... |
|
This would be very valuable for my team. Thanks for contributing this! |
|
I've started splitting these changes up into smaller, bitesize pull-requests.
Once they are approved and merged, I will update this pull-request. Thx. |
|
👍 It's always easier to review smaller PRs 👍 |
|
as the changes has been merged, can we close this PR to do not mislead people that AWS AppSync is not working with this client?
|
|
Closing as beeing outdated... |
The following changes allow me to use GraphQL.Client from a Blazor WebAssembly app. Please review and let me know what I need to address before submitting a pull-request.
Changes:
WebSocketEndPointproperty to allow specifying a separate websocket endpoint.PreprocessSubscriptionRequestto disambiguate between query and subscription pre-processing.Console.WriteLine()statements toDebug.WriteLine().Debug.WriteLine()to help with debugging the AppSync protocol.