Skip to content

Separate pagination type fix #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 28, 2020
Merged

Conversation

theasmoth
Copy link
Contributor

Hi @nodkz. I've faced issue using this package.

I have multiple pagination resolvers with one TC with little differences in output TC. When i try to fetch first pagination it replaces with last defined, because resolverName not used in output TC name.

Спасибо за либу 🙂 👍

@codecov-io
Copy link

Codecov Report

Merging #35 (a2a56eb) into master (3e83003) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files           3        3           
  Lines          90       90           
  Branches       29       29           
=======================================
  Hits           88       88           
  Misses          2        2           
Impacted Files Coverage Δ
src/pagination.ts 96.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e83003...a2a56eb. Read the comment docs.

@nodkz nodkz merged commit 1a8aa26 into graphql-compose:master Dec 28, 2020
@nodkz
Copy link
Member

nodkz commented Dec 28, 2020

Good catch! Thanks a lot 👍

@github-actions
Copy link

🎉 This PR is included in version 8.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants