Custom filters breaks mongo queries with 9.0.1

[fklingler]

Hello, I encountered a bug with the newer versions of graphql-compose-mongoose.

I have this custom filter added to my findMany resolver:

    .addFilterArg({
        name: 'from',
        type: GraphQLDate,
        description: 'Appointment date should be after the provided date.',
        query: (rawQuery: any, value: Date) => {
            rawQuery.date = {
                $gte: value,
                ...(rawQuery.date && typeof(rawQuery.date) != 'object'
                    ? { $eq: rawQuery.date }
                    : (rawQuery.date ?? {}))
            };
        }
    })

When using this filter, the mongo query should be like this (and was like this up to 9.0.0):

appointments.find({ date: { '$gte': new Date("Fri, 01 Jan 2021 23:00:00 GMT") }}, { limit: 100, projection: { _id: true, name: true }})

Now it is like this:

appointments.find({ from: new Date("Fri, 01 Jan 2021 23:00:00 GMT"), date: { '$gte': new Date("Fri, 01 Jan 2021 23:00:00 GMT") }}, { limit: 100, projection: { _id: true, name: true }})

Note the added from field in the find query, that makes it return no document.

This bug has been introduced in 9.0.1, the faulty commit is probably this one 313ea1f

[pescoboza]

I am having the same issue. This is the filter arg I tested:

.addFilterArg({
        name: 'bedroomsTest',
        type: 'input BedInput {gte:Int, lte: Int}',
        query: (rawQuery, value, rp) => {
            console.log({ rawQuery, value });

            rawQuery['specs.bedrooms'] = { $gte: value.gte, $lte: value.lte };
            console.log({ rawQuery, value });
        },
    })

Here's what gets called by mongoose:

Mongoose: properties.find({ 'bedroomsTest.gte': 1, 'bedroomsTest.lte': 10, 'specs.bedrooms': { '$gte': 1, '$lte': 10 }}, { limit: 100, projection: { _id: true, displayName: true, 'specs.bedrooms': true }})

Great library BTW : )

[pescoboza]

The problem seems to be around the filter helpers.

It looks like the params gql params are inserted themselves before the actual rawQuery applied by addFilterArg.

Fiddled around with the debugger and got this:

[nodkz]

@pescoboza thanks for the investigation. It helps greatly to resolve this issue!

@fklingler your issue added as test-case https://github.com/graphql-compose/graphql-compose-mongoose/blob/master/src/__tests__/github_issues/315-test.ts

A new package version will be published in minutes.

[github-actions]

🎉 This issue has been resolved in version 9.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀