Subgraph composition: TriggersAdapterWrapper refactor #5602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
6428449 to
548d11c
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
151779b to
304e5df
Compare
incrypto32
changed the title
incrypto32
force-pushed
the
subgraph-composition-interfacing
branch
from
548d11c to
44c0385
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
b4ad24f to
b35754e
Compare
mangas
reviewed
Nov 11, 2024
mangas
reviewed
Nov 11, 2024
| Range(BlockNumber, BlockNumber), | ||
| } | ||
|
|
||
| async fn scan_subgraph_triggers<C: Blockchain>( |
There was a problem hiding this comment.
is there any testing on these, specifically to ensure the comments on the code hold true like the range is inclusive etc
There was a problem hiding this comment.
I will dedicate a PR to more intensive testing in the end of this PR chain so that i have all the relevant changes ready before the testing
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
44c0385 to
2a20ebd
Compare
zorancv
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
2 times, most recently
from
1f66779 to
51950cb
Compare
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
0874d28 to
44c0385
Compare
zorancv
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
51950cb to
72c8848
Compare
incrypto32
force-pushed
the
subgraph-composition-interfacing
branch
from
44c0385 to
47343bc
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
72c8848 to
eb3f792
Compare
zorancv
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
eb3f792 to
943f821
Compare
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
722c58c to
2d74500
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
943f821 to
24487d8
Compare
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
2d74500 to
13ee252
Compare
incrypto32
force-pushed
the
subgraph-composition-interfacing
branch
from
13ee252 to
2d74500
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
b279c2c to
24487d8
Compare
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
2d74500 to
0c0f383
Compare
zorancv
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
24487d8 to
d8eb30e
Compare
zorancv
force-pushed
the
subgraph-composition-interfacing
branch
from
0c0f383 to
3814175
Compare
zorancv
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
d8eb30e to
37bf3cd
Compare
incrypto32
force-pushed
the
subgraph-composition-interfacing
branch
from
3814175 to
9c380c4
Compare
incrypto32
force-pushed
the
krishna/subgraph-composition-triggers-adapter-refactor
branch
from
37bf3cd to
1fc017f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just some refactoring of the TriggersAdapterWrapper to move some functionalities like scanning for subgraph triggers into its on functions