Defer fragment support #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CNAChino
reviewed
Feb 27, 2023
src/main/java/com/intuit/graphql/orchestrator/batch/AuthDownstreamQueryModifier.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Feb 27, 2023
src/main/java/com/intuit/graphql/orchestrator/batch/AuthDownstreamQueryModifier.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Feb 27, 2023
| if(!node.getDirectives(DEFER_DIRECTIVE_NAME).isEmpty()) { | ||
| Argument deferArg = node.getDirectives(DEFER_DIRECTIVE_NAME).get(0).getArgument(DEFER_IF_ARG); | ||
| if(graphQLContext.getOrDefault(USE_DEFER, false) && (deferArg == null || ((BooleanValue)deferArg.getValue()).isValue())) { | ||
| decreaseParentSelectionSetCount(context.getParentContext()); |
Contributor
There was a problem hiding this comment.
If I understood this correctly, USE defer is a feature flag? If yes, throwing an exception might be a good option as well. i.e. if feature is not enabled but someone use defer, we can throw an exception
Collaborator
Author
There was a problem hiding this comment.
I was assuming the feature flag would set hasDefer to false and forward to regular graphql execute to avoid clients queries breaking if we suddenly turn it off
CNAChino
reviewed
Feb 27, 2023
|
|
||
| if(!node.getDirectives(DEFER_DIRECTIVE_NAME).isEmpty()) { | ||
| Argument deferArg = node.getDirectives(DEFER_DIRECTIVE_NAME).get(0).getArgument(DEFER_IF_ARG); | ||
| if(graphQLContext.getOrDefault(USE_DEFER, false) && (deferArg == null || ((BooleanValue)deferArg.getValue()).isValue())) { |
Contributor
There was a problem hiding this comment.
looks like this code is repeated
CNAChino
reviewed
Feb 27, 2023
src/main/java/com/intuit/graphql/orchestrator/deferDirective/MultipartQueryRequest.java
Outdated
Show resolved
Hide resolved
CNAChino
reviewed
Feb 27, 2023
src/main/java/com/intuit/graphql/orchestrator/batch/GraphQLServiceBatchLoader.java
Show resolved
Hide resolved
kmoore-intuit
force-pushed
the
defer-fragment-support
branch
from
1e9f643 to
7a0900e
Compare
CNAChino
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Todo: