chore: optimize metrics for discarded data in distributor #4248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
commented
Jun 12, 2025
Comment on lines
-1078
to
+1083
| if err := validation.ValidateLabels(v.limits, v.tenantID, labels); err != nil { | ||
| return connect.NewError(connect.CodeInvalidArgument, err) | ||
| } | ||
| return nil | ||
| return validation.ValidateLabels(v.limits, v.tenantID, labels) |
There was a problem hiding this comment.
It feels like it's the caller's responsibility to wrap the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I noticed while working on #4236: we unconditionally update the
DiscardedBytesandDiscardedProfilesmetrics after relabeling:It's not a major issue, but in large-scale deployments with hundreds of distributors and tenants, we generate many time series unnecessarily (it's very unlikely that we ever need to report anything in this particular place). Additionally, having to filter with
> 0in each query is annoying