Skip to content

Conversation

korniltsev
Copy link
Contributor

No description provided.

@korniltsev korniltsev requested a review from a team as a code owner January 6, 2025 09:11
@korniltsev korniltsev added the type/bug Something isn't working label Jan 6, 2025
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

At which point are we checking that StringTable[0] == ""? I can find it right now, but I pretty sure we do it...

@korniltsev korniltsev force-pushed the korniltsev/distributor_string_oob_fix branch from a0280b1 to d3fc4d2 Compare January 6, 2025 09:22
@korniltsev
Copy link
Contributor Author

I've added a case for empty string just in case

@korniltsev korniltsev enabled auto-merge (squash) January 6, 2025 09:27
@korniltsev korniltsev force-pushed the korniltsev/distributor_string_oob_fix branch from d3fc4d2 to 92a114a Compare January 6, 2025 09:40
@korniltsev korniltsev merged commit b362e0e into main Jan 6, 2025
18 checks passed
@korniltsev korniltsev deleted the korniltsev/distributor_string_oob_fix branch January 6, 2025 09:49
shelldandy pushed a commit to shelldandy/pyroscope that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants