Remove type parameters from go names #2343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
commented
Aug 31, 2023
| @@ -92,7 +92,7 @@ func (l *Limits) RegisterFlags(f *flag.FlagSet) { | |||
| f.IntVar(&l.MaxProfileStacktraceSamples, "validation.max-profile-stacktrace-samples", 16000, "Maximum number of samples in a profile. 0 to disable.") | |||
| f.IntVar(&l.MaxProfileStacktraceSampleLabels, "validation.max-profile-stacktrace-sample-labels", 100, "Maximum number of labels in a profile sample. 0 to disable.") | |||
| f.IntVar(&l.MaxProfileStacktraceDepth, "validation.max-profile-stacktrace-depth", 1000, "Maximum depth of a profile stacktrace. Profiles are not rejected instead stacktraces are truncated. 0 to disable.") | |||
| f.IntVar(&l.MaxProfileSymbolValueLength, "validation.max-profile-symbol-value-length", 1024, "Maximum length of a profile symbol value (labels, function names and filenames, etc...). Profiles are not rejected instead symbol values are truncated. 0 to disable.") | |||
| f.IntVar(&l.MaxProfileSymbolValueLength, "validation.max-profile-symbol-value-length", 65535, "Maximum length of a profile symbol value (labels, function names and filenames, etc...). Profiles are not rejected instead symbol values are truncated. 0 to disable.") | |||
There was a problem hiding this comment.
The limit is increased as length of 1024 is too short for Go:
In practice we already have profile size limit therefore this one might not be required. Because of the string truncation it's easy to make profiles unreadable (e.g such profiles are useless for PGO)
kolesnikovae
commented
Aug 31, 2023
Comment on lines
+10
to
+24
| func DropGoTypeParameters(input string) string { | ||
| matchesIndices := goStructTypeParameterRegex.FindAllStringIndex(input, -1) | ||
| if len(matchesIndices) == 0 { | ||
| return input | ||
| } | ||
| var modified strings.Builder | ||
| prevEnd := 0 | ||
| for _, indices := range matchesIndices { | ||
| start, end := indices[0], indices[1] | ||
| modified.WriteString(input[prevEnd:start] + "[...]") | ||
| prevEnd = end | ||
| } | ||
| modified.WriteString(input[prevEnd:]) | ||
| return modified.String() | ||
| } |
There was a problem hiding this comment.
Note that we don't know if it is a Go profile / node, therefore the function is applied to all nodes. ReplaceAllString would look better here but it allocates a new string.
I'm also not sure if there might be more than one group of type parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2241.
Replaces Go type parameters with ellipses as it was before go 1.21.0.