Remove negative samples #2283
Merged
Remove negative samples #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
approved these changes
Aug 21, 2023
Closed
simonswine
approved these changes
Aug 21, 2023
|
|
||
| func (t *Tree) InsertStack(v int64, stack ...string) { | ||
| if v <= 0 { | ||
| return |
There was a problem hiding this comment.
I think silently dropping sample values is good enough to stop the bleed, but I think longer term we need to make sure that sample values won't get that far and are filtered during the upload (Grafana Agent, SDKs).
Let's maybe create an issue to not forget about this
There was a problem hiding this comment.
Yeah, it makes sense to better understand the problem. Created an issue #2285 – will take a closer look later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #2282 and #2179.